Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync cmd: Display errors that don't abort the program as normal UI actions #106

Merged
merged 5 commits into from
Sep 14, 2024

Conversation

andygrunwald
Copy link
Collaborator

@andygrunwald andygrunwald commented Sep 13, 2024

Some errors don't need to stop the whole app.
Those errors will now be displayed in the same way as any other successful message.

For the screenshot, I added one test error.
Screenshot 2024-09-13 at 21 14 13

Merge order

This PR is based on #105
#105 need to be merged before.

@andygrunwald andygrunwald changed the base branch from main to show-action-items-in-sync-command September 14, 2024 08:09
@andygrunwald andygrunwald changed the base branch from show-action-items-in-sync-command to main September 14, 2024 08:10
Copy link
Contributor

@brgmn brgmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@andygrunwald andygrunwald merged commit 5a8f475 into main Sep 14, 2024
2 checks passed
@andygrunwald andygrunwald deleted the collect-errors-like-success-actions branch September 14, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants