fix: evaluation polling interval setting #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
masaaania
commented
Aug 21, 2023
masaaania
commented
- This PR fixes the bug unable to set polling interval.
- The value of the events flush interval was set to the evaluation polling interval by mistake.
- And changes the example application's polling interval setting to 150 seconds from 5 seconds.
- The minimum polling interval is 60 seconds, and if a lower value is specified, it is automatically reset to 60 seconds. It creates confusion for users of the example app.
- Also, I prefer to set a different value from the events flush interval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.