Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint pod fail #41

Merged
merged 3 commits into from
Sep 8, 2023
Merged

fix: lint pod fail #41

merged 3 commits into from
Sep 8, 2023

Conversation

duyhungtnn
Copy link
Collaborator

@duyhungtnn duyhungtnn commented Sep 8, 2023 •
edited
Loading

This PR should fix https://github.com/bucketeer-io/ios-client-sdk/actions/runs/6117473016

Changes

  • Update GitHub Action PR's flow to check the pod lint
  • Fix missing check for tvOS13
  • Fix tvOS example could not build

@duyhungtnn duyhungtnn marked this pull request as ready for review September 8, 2023 07:28
@duyhungtnn
Copy link
Collaborator Author

@cre8ivejp please help me to take a look

cre8ivejp
cre8ivejp approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cre8ivejp cre8ivejp merged commit 99fd16a into bucketeer-io:main Sep 8, 2023
8 checks passed
@bucketeer-bot bucketeer-bot mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ivejp cre8ivejp cre8ivejp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duyhungtnn @cre8ivejp