feat: update iOS SDK #5
Conversation
|
@cre8ivejp Hi, this PR is ready for review. Please help me to take a look. Let me know if you see any problems. Thank you. |
duyhungtnn
force-pushed
the
feat/update-iOS-SDK
branch
from
51dd400
to
e1fb54c
Compare
duyhungtnn
force-pushed
the
feat/update-iOS-SDK
branch
from
e1fb54c
to
2efb404
Compare
|
I think we don't need the Please fix the warning in this line. init(
apiEndpoint: URL,
apiKey: String,
... |
| @@ -571,4 +571,4 @@ final class EventInteractorTests: XCTestCase { | |||
| wait(for: [expectation], timeout: 1) | |||
| } | |||
| } | |||
| // swiftlint:enable [type_body_length file_length] | |||
| // swiftlint:enable type_body_length file_length | |||
There was a problem hiding this comment.
Just confirming. Does it need to enable at the end of the file?
There was a problem hiding this comment.
yes, we need to re-enable it at the end of the file, otherwise we will have one more warning like that
| @@ -94,4 +94,68 @@ extension BKTError { | |||
| self = .unknown(message: "Unknown error: \(error)", error: error) | |||
| } | |||
| } | |||
|
|
|||
| /// A localized message describing what error occurred. | |||
| public var errorDescription: String? { | |||
There was a problem hiding this comment.
I saw a problem when updating Flutter SDK, I need many switch cases to read the error.
So that I added the code below :
-> Support SDK's consumer read error messages the easy way.
@cre8ivejp
There was a problem hiding this comment.
Does this change need to be done also in Android SDK?
There was a problem hiding this comment.
I will check when I am updating the Flutter for Android and send new PR to Android SDK if needed
| let id: String | ||
| let attr: [String: String] | ||
| public let id: String | ||
| public let attr: [String: String] |
There was a problem hiding this comment.
BKUser's properties are internal access so that the SDK's consumer (Flutter) cannot access the current user data.
It makes BKTClient.getCurrentUser() useless
| @@ -571,4 +571,4 @@ final class EventInteractorTests: XCTestCase { | |||
| wait(for: [expectation], timeout: 1) | |||
| } | |||
| } | |||
| // swiftlint:enable [type_body_length file_length] | |||
| // swiftlint:enable type_body_length file_length | |||
There was a problem hiding this comment.
yes, we need to re-enable it at the end of the file, otherwise we will have one more warning like that
| // MetricsEventDataTests.swift | ||
| // BucketeerTests | ||
| // | ||
| // Created by Ryan Hung Pham on 15/06/2023. |
There was a problem hiding this comment.
Please delete the header. I'm planning to run a script to add it to all files.
There was a problem hiding this comment.
I removed the header
Changes
ReasonTypetointernalscopeRefs
bucketeer-io/android-client-sdk#64
bucketeer-io/android-client-sdk#68