-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update error metrics report #68
Conversation
56ac72e
to
2df7258
Compare
hi, @kakcy please help me to take a look at this PR. Let me know if you see any problems or questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
I have made some comments, please check them.
@@ -250,18 +268,20 @@ extension BKTError: CaseIterable { | |||
} | |||
|
|||
public static var allCases: [BKTError] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think .invalidHttpMethod
should be added to this array, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 3ec923d
BucketeerTests/ApiClientTests.swift
Outdated
timeoutMillis: 100) { (result: Result<(MockResponse, URLResponse), Error>) in | ||
switch result { | ||
case .success((let response, _)): | ||
XCTAssertEqual(response, mockResponse) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it will be called here, so I think XCTFail() is better, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 8501d05
Thank @kakcy for reviewing, let me update the PR follow your suggestion. |
Hi @kakcy please help me to review again. I updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
I reviewed it and it seems to be fine.
thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thank you!
Part of bucketeer-io/bucketeer#799
Related to #65
TODO
response_code
via labelserror_message
andresponse_code
to the ErrorMetricsEvent labelsTests
response_code
via labelserror_message
andresponse_code
to the ErrorMetricsEvent labels