Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux app-manager restore installation failed when app-manager breaks down when DEC APP is running "npm i" #239

Closed
Tracked by #227
lizhihongTest opened this issue Apr 23, 2023 · 4 comments
Assignees
Labels
App-Manager The App Manager basic service bug Something isn't working

Comments

@lizhihongTest
Copy link
Collaborator

Describe the bug
Linux app-manager restore installation failed when app-manager breaks down when DEC APP is running "npm i"

To Reproduce

  • Install dec-app-service-many-npm-packages cyfs://5r4MYfFJ7ktzBzSi1sWmU7BJLgpEEdp8ukbWemsFuQc1/9tGpLNnPZPoULTFVB6tbzrLkHS564isyc54PmWuNW6DT
  • When DEC APP is running "npm i", kill the app-manager process
  • When the app-manager is restarted by ood-daemon,Check the result of this app`status.

Expected behavior
The app-manager will reinstall 9tGpLNnPZPoULTFVB6tbzrLkHS564isyc54PmWuNW6DT and Installfailed

System information
Nighlty : 1.1.0.753-preview
OOD System : cyfs-test-lab::PC-0005(Ubuntu22)

app-manager_267347_rCURRENT.log

app-manager_261428_rCURRENT.log

@weiqiushi
Copy link
Member

The cause of this problem is different from #207, the direct cause is that for some reason the docker startup script does not exist when starting docker, resulting in an error executing the install command in docker

The root cause of this problem is not yet clear and requires further testing

@lurenpluto
Copy link
Member

Here's a question: If a dec app is installed and the app-manager process quits or restarts for some reason, what happens to the old installation process? Will it quit or will it continue? Does the new app-manager process clean up the old installation process and retrigger the installation after it starts?

@lurenpluto lurenpluto moved this to 💬To Discuss in CYFS-Stack & Services Apr 26, 2023
@weiqiushi
Copy link
Member

Here's a question: If a dec app is installed and the app-manager process quits or restarts for some reason, what happens to the old installation process? Will it quit or will it continue? Does the new app-manager process clean up the old installation process and retrigger the installation after it starts?

Testing has shown that if app-manager exits during the execution of the install command, the install process usually continues to exist:

  • On Windows, app-manager exits without affecting the child processes, and the install process exist
  • On Linux, app-manager start the installation in docker, the app-manager kills the docker run process when it exits, but the docker container exist

Under the new logic of app-manager, when app-manager restarts, it will start the installation logic again. In this installation logic, the previously started installation process or the container was be killed.

@weiqiushi weiqiushi moved this from 💬To Discuss to 🧪To Test in CYFS-Stack & Services May 4, 2023
@lizhihongTest
Copy link
Collaborator Author

This issue has checked been fixed in version 1.1.0.755

@lizhihongTest lizhihongTest moved this from 🧪To Test to ✅Done in CYFS-Stack & Services May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App-Manager The App Manager basic service bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants