Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added device_id support via ENV variable or auto uuid values #104

Merged
merged 4 commits into from
Jul 31, 2018

Conversation

devilankur18
Copy link
Contributor

@devilankur18 devilankur18 commented Jul 28, 2018

Purpose of changes

Currently not able to set custom device id for emulator

Types of changes

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

While launching the docker image, passing the device_id value via environmrnt variable will launch the emulator with that mentioned device_id or an auto generate UUID will be set instead.

@codecov-io
Copy link

codecov-io commented Jul 28, 2018

Codecov Report

Merging #104 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage    98.3%   98.34%   +0.04%     
==========================================
  Files           2        2              
  Lines         118      121       +3     
==========================================
+ Hits          116      119       +3     
  Misses          2        2
Impacted Files Coverage Δ
src/app.py 98.27% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0271e0...c4be3a1. Read the comment docs.

Copy link
Owner

@budtmo budtmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devilankur18 ,

Thank you for the PR. it looks good to me.
Could you maybe fix a small codacy violation in this PR? so I can merge it

Copy link

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Repository owner deleted a comment Jul 30, 2018
@budtmo budtmo merged commit d13e60a into budtmo:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants