Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Statement Fields? #79

Open
andyl opened this issue Jun 18, 2018 · 1 comment
Open

Rename Statement Fields? #79

andyl opened this issue Jun 18, 2018 · 1 comment
Labels
9 discuss API

Comments

@andyl
Copy link
Collaborator

andyl commented Jun 18, 2018

Currently we have statement fields which are used in Issue, Offer, and Contract.

  • stm_title
  • stm_body
  • stm_issue_uuid
  • stm_tracker_uuid
  • stm_status

The statement field names are the same across all classes, but the purpose differs:

  • Issue - holds the source data
  • Offer and Contract - query values used to match and evaluate

For our field-names to be more intention revealing, probably it would be good to either:

  • rename the fields on Issue (eg stm_title -> src_title)
  • rename the fields on Offer and Contract (eg stm_title -> match_title)
@GeorgLink
Copy link
Collaborator

I like both rename suggestions equally well, maybe do both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
9 discuss API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andyl @GeorgLink