test: Add JsonWriter test from GSON repo #315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improve code coverage for JsonWriter by using existing tests in GSON repository. This should give more confidence to update the library in future.
Changeset
Added
A test from the GSON repo.
Discussion
Alternative Approaches
I've done a little monkey-patching by adding
Test
annotations to get this running on our current setup. I have also editedtestTopLevelValueTypes
as the API syntax appears to have changed in later versions of GSON, and omittedtestNonFiniteDoublesWhenLenient
entirely as it appears our notifier contains an older version of JsonWriter which is affected by this bug.Outstanding Questions
Should we also update JsonWriter with this change?
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: