Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add JsonWriter test from GSON repo #315

Merged
merged 3 commits into from
May 14, 2018
Merged

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented May 11, 2018

Goal

Improve code coverage for JsonWriter by using existing tests in GSON repository. This should give more confidence to update the library in future.

Changeset

Added

A test from the GSON repo.

Discussion

Alternative Approaches

I've done a little monkey-patching by adding Test annotations to get this running on our current setup. I have also edited testTopLevelValueTypes as the API syntax appears to have changed in later versions of GSON, and omitted testNonFiniteDoublesWhenLenient entirely as it appears our notifier contains an older version of JsonWriter which is affected by this bug.

Outstanding Questions

Should we also update JsonWriter with this change?

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

Adds a missing test for JsonWriter which improves code coverage. testNonFiniteDoublesWhenLenient has
been omitted as it currently fails in our version of JsonWriter.
@fractalwrench fractalwrench requested a review from a team May 11, 2018 16:54
@coveralls
Copy link

coveralls commented May 14, 2018

Coverage Status

Coverage increased (+0.6%) to 77.212% when pulling f742fe5 on add-jsonwriter-test into 4e1727a on master.

@fractalwrench fractalwrench merged commit f9a8e91 into master May 14, 2018
@fractalwrench fractalwrench deleted the add-jsonwriter-test branch May 14, 2018 13:06
lemnik pushed a commit that referenced this pull request Jun 2, 2021
Support Unity builds using internal Gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants