Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of github.com/bugsnag/osext instead of github.com/kardianos/osext #54

Closed
peterhellberg opened this issue Aug 7, 2017 · 2 comments

Comments

@peterhellberg
Copy link

peterhellberg commented Aug 7, 2017

Problem

github.com/bugsnag/osext is imported in panicwrap_test.go

But https://github.com/bugsnag/panicwrap is using github.com/kardianos/osext

Is this intentional?

Expected

That both bugsnag-go and panicwrap would import the same version of osext.

(github.com/kardianos/osext)

Note

I found this issue while trying to use dep to vendor bugsnag-go.

Since bugsnag-go depends on github.com/bugsnag/osext then the latest version of github.com/bugsnag/panicwrap that can be used is https://github.com/bugsnag/panicwrap/tree/1.1.0 instead of the (i believe) intended master branch.

@peterhellberg
Copy link
Author

We haven't noticed this issue when using govendor since it removes test files (panicwrap_test.go)

@kattrali
Copy link
Contributor

kattrali commented Aug 7, 2017

Thanks for the report, @peterhellberg. This looks like an oversight from bugsnag/panicwrap#3. Updating accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants