Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety concern to use thread_queue delivery method in Resque and Sidekiq #593

Closed
arthurchui opened this issue May 7, 2020 · 4 comments
Closed
Labels
feature request Request for a new feature released This feature/bug fix has been released

Comments

@arthurchui
Copy link

We use Ruby MRI to run Resque and Sidekiq. Sometimes, our code sends reports to Bugsnag within active db transaction blocks. To avoid long transactions, we prefer to defer the API calls after committing the db transactions.

Since v2.6 (#180), Bugsnag chose synchronous method for Resque and Sidekiq. #180 pointed out that Resque had an issue with ThreadQueue.

After ~6 years, I wonder if it is safe to turn on thread_queue now.

@abigailbramble
Copy link

Hi @arthurchui
Unfortunately, this cannot be threaded. The reason we have chosen synchronous is so that the error report finishes sending before the job terminates. If this does not happen, the termination of the job interrupts the notification being sent to Bugsnag.

@arthurchui
Copy link
Author

Hi @phillipsam . Thanks for your reply. I wonder the at_exit hook should send the outstanding reports to Bugsnag before the job terminates, right?

@abigailbramble
Copy link

Hi @arthurchui it looks like this is something we could explore when priorities allow. Let us know if you have further comments in the meantime.

@abigailbramble abigailbramble added backlog We hope to fix this feature/bug in the future feature request Request for a new feature labels May 13, 2020
@bugsnagbot bugsnagbot added scheduled Work is starting on this feature/bug and removed backlog We hope to fix this feature/bug in the future labels Jul 7, 2020
@johnkiely1
Copy link
Member

This has now been released in v6.17.0

@johnkiely1 johnkiely1 added released This feature/bug fix has been released and removed scheduled Work is starting on this feature/bug labels Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature released This feature/bug fix has been released
Projects
None yet
Development

No branches or pull requests

4 participants