Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Queries break for some common attributes #5248

Closed
erikkerber opened this issue Nov 9, 2023 · 2 comments · Fixed by #5263
Closed

[CLI] Queries break for some common attributes #5248

erikkerber opened this issue Nov 9, 2023 · 2 comments · Fixed by #5263

Comments

@erikkerber
Copy link

Describe the bug

In our .bazelrc we had JDK 11 specified under common:

common --java_runtime_version=remotejdk_11
common --tool_java_runtime_version=remotejdk_11
common --repo_env=JAVA_HOME=../bazel_tools/jdk

When installing the CLI via .bazelversion, queries then broke with an invalid option applied:

ERROR: --java_runtime_version=remotejdk_11 :: Unrecognized option: --java_runtime_version=remotejdk_11

Changing those to build resolves, but it feels like a bug that the wrapper isn't a pure passthrough in this instance

To Reproduce
(Above)

Expected behavior

The wrapper is completely transparent to regular Bazel operations

@sluongng
Copy link
Contributor

sluongng commented Nov 9, 2023

This is something that we have tracked internally.

Our CLI currently does not understand the new common keyword logic in .bazelrc (since bazelbuild/bazel#18130) and we gonna need to rework our parser to make it happen.

@erikkerber erikkerber changed the title [CLI] Queries break if for some common attributes [CLI] Queries break for some common attributes Nov 14, 2023
@bduffany
Copy link
Member

bduffany commented Nov 14, 2023

@erikkerber the fix for this is now released in CLI version 5.0.25 - let us know if you run into other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants