Track dependency objects even if they don't exist #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to track objects that don't exist yet. Issue: buildpacks-community#1028
gcapizzi
force-pushed
the
track-by-key
branch
from
284d88a to
07bd68d
Compare
gcapizzi
force-pushed
the
track-by-key
branch
from
07bd68d to
9cc64df
Compare
matthewmcnew
requested review from
tylerphelan,
jjbustamante,
matthewmcnew,
chenbh and
ncarlson
and removed request for
tylerphelan and
jjbustamante
matthewmcnew
approved these changes
Dec 2, 2022
|
Thanks @gcapizzi |
tomkennedy513
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1028.
In order to be able to track objects that don't exist yet,
tracker.Trackertracks objects by areconciler.Keyconsisting of itsschema.GroupKindand itstypes.NamespacedName.Given the
schema.GroupKindis derived from the objectTypeMeta, I made sure that every object instantiated in tests has it set. I believe this should also be the case in production.In order to make sure the
schema.GroupKindwas properly taken into account, I modified thetesthelpers.FakeTrackerto use the fullreconciler.Keyas its tracking key.I wasn't able to run the end-to-end tests locally, unfortunately. Unit tests are passing but it would be nice if someone on the team could check the end-to-ends are also happy.
Please take a look and let me know how it looks!