Use keychain from clusterstack to pull build image in CreateBuild #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomkennedy513
commented
May 24, 2023
tomkennedy513
commented
- fallback to builder keychain if there is no service account on the clusterstack to mimic existing behavior
- fallback to builder keychain if there is no service account on the clusterstack to mimic existing behavior
tomkennedy513
requested review from
matthewmcnew,
chenbh,
yaelharel and
pviraj59
as code owners
chenbh
approved these changes
May 24, 2023
| ServiceAccount: builder.Spec.ServiceAccount(), | ||
| Namespace: builder.Namespace, | ||
| }) | ||
| if err != nil { | ||
| return buildapi.BuilderRecord{}, err | ||
| } | ||
|
|
||
| stackKeychain := builderKeychain |
There was a problem hiding this comment.
I'm a little hesitant on falling back to the stack keychain, this feels like compromising design for backwards compatibility. That being said, I'm not too married to this idea and certainly not enough to block this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.