Returns error if build does not start successfully with kp create image --wait
#1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkennedy513
approved these changes
Aug 29, 2023
chenbh
reviewed
Aug 29, 2023
Comment on lines
+102
to
+103
| fmt.Fprintf(writer, "Build failed to start: %s", err) | ||
| return "", nil |
There was a problem hiding this comment.
We should toss the error back up the chain instead of trying to handle it here
Suggested change
| fmt.Fprintf(writer, "Build failed to start: %s", err) | |
| return "", nil | |
| return "", fmt.Errorf("build failed to start: %s", err) |
Comment on lines
+101
to
+115
| if err != nil { | ||
| fmt.Fprintf(writer, "Build failed to start: %s", err) | ||
| return "", nil | ||
| } else { | ||
| doneChan := make(chan struct{}) | ||
| defer func() { <-doneChan }() | ||
|
|
||
| go func() { // tail logs | ||
| defer close(doneChan) | ||
| err := w.logTailer.TailBuildName(ctx, writer, namespace, buildName) | ||
| if err != nil { | ||
| fmt.Fprintf(writer, "error tailing logs %s", err) | ||
| } | ||
| }() | ||
| } |
There was a problem hiding this comment.
|
|
||
| condition := build.Status.GetCondition(corev1alpha1.ConditionSucceeded) | ||
| if condition.IsFalse() { | ||
| return errors.New(condition.Message) |
There was a problem hiding this comment.
Suggested change
| return errors.New(condition.Message) | |
| return buildFailure(condition.Message) |
kpack/pkg/logs/wait_for_image.go
Lines 137 to 144 in ca60665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves buildpacks-community/kpack-cli#194