Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve SBOM validation #272

Closed
wants to merge 8 commits into from
Closed

Conversation

sagnik3788
Copy link

Resolves #126

Signed-off-by: sagnik3788 <sagnikdas5432@gmail.com>
@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Feb 6, 2024
@dmikusa
Copy link
Contributor

dmikusa commented Feb 6, 2024

Can you add a test case here that proves this change fixes the issue?

The idea would be to do something like change sbom-formats = ["application/vnd.cyclonedx+json"] to sbom-formats = ["application/vnd.cyclonedx+json;charset=us-ascii"]. I don't know if that's valid, but I'm pretty sure that will fail using the current methods. Because it will detect the media type as one of these options (https://github.com/buildpacks/libcnb/blob/main/layer.go#L96-L101), which don't match exactly.

@dmikusa
Copy link
Contributor

dmikusa commented Apr 9, 2024

Hi @sagnik3788, just wanted to follow up and see how things are going. Did you see my previous note? Are you still interested in submitting a code change here? Thanks!

@dmikusa
Copy link
Contributor

dmikusa commented Jun 19, 2024

Closing as we need some test coverage to be able to merge this. @sagnik3788 if you want to pick this back up feel free to send a new PR. Thanks

@dmikusa dmikusa closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax SBOM validation
2 participants