Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC #0105] Rebaser changes for run image extension (Dockerfiles phase 3) #1000

Closed
Tracked by #224
natalieparellano opened this issue Feb 2, 2023 · 0 comments · Fixed by #1032
Closed
Tracked by #224

[RFC #0105] Rebaser changes for run image extension (Dockerfiles phase 3) #1000

natalieparellano opened this issue Feb 2, 2023 · 0 comments · Fixed by #1032
Assignees
@jabrown85
Labels
status/ready type/enhancement New feature or request
Milestone
lifecycle 0.17.0

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Feb 2, 2023 •
edited

Spec PR: https://github.com/buildpacks/spec/pull/347/files

For newer platform API (0.12 and above), the rebaser should require -force if the image has the label io.buildpacks.rebasable set to false.

Additionally:

- **If** `<run-image>` is not provided by the platform, the value will be [resolved](#run-image-resolution) from the contents of the `runImage` key in the `io.buildpacks.lifecycle.metdata` label on `<image>`

Thus instead of stack.runImage.image we use runImage.image on the label (note the schema change in the spec PR).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jabrown85 jabrown85

Labels
status/ready type/enhancement New feature or request
Projects
None yet
Milestone
lifecycle 0.17.0
Development

Successfully merging a pull request may close this issue.

Rebaser changes for run image extension buildpacks/lifecycle
2 participants
@jabrown85 @natalieparellano