-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 0116] Stop deleting cache images for newer Platform API versions #803
Comments
Thank you for raising this issue. @natalieparellano can you please move this to lifecycle? |
Adding this for discussion as we're not sure if we should just do a regex on ECR, or perhaps have this be a setting that the platform can pass in. |
Just brainstorming a few more alternatives:
|
@ekcasey I like not deleting cache images at all. I wasn't sure anyone would go for that though 😄 We have code around here that essentially removes the log lines because of another registry that doesn't allow delete and it confuses users since there is no action to take. |
Discussed during 3/30 sync - we think the best path forward is to not delete the cache image at all, leaving it up to the platform. We should gate this behavior on a platform api version, so the change is not unexpected. This would require a sub-team RFC. |
@natalieparellano have we done a sub-team RFC before? Are those in buildpacks/rfcs and just tagged a certain way? Happy to create the RFC, just not sure I've seen one. |
@jabrown85 yep, sub team RFCs are just regular RFCs with the |
Opened RFC here. |
I have updated the title of this issue to reflect the approved RFC |
FWIW, I just got this email from Amazon:
|
The RFC was merged but it's not yet implemented :) |
Description
AWS ECR does not support the delete image registry API used by pack. See aws/containers-roadmap#1229
When publishing a cache image to an ECR registry, users get the following error:
It doesn't seem to cause any issues, but looks like a problem for end-users.
Proposed solution
Well ideally AWS would fix their implementation, but the issue has been open for a year with no movement. Perhaps pack could detect ECR repos (maybe by an URL regex 🤷) and skip this step or perform the deletion by other means.
Describe alternatives you've considered
I just ignore the log line and move on.
Additional context
The text was updated successfully, but these errors were encountered: