Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC #0105] Restorer changes for run image extension (Dockerfiles phase 3) #997

Closed
Tracked by #224
natalieparellano opened this issue Feb 2, 2023 · 2 comments · Fixed by #1014
Closed
Tracked by #224

[RFC #0105] Restorer changes for run image extension (Dockerfiles phase 3) #997

natalieparellano opened this issue Feb 2, 2023 · 2 comments · Fixed by #1014
Assignees
@natalieparellano
Labels
status/ready type/enhancement New feature or request
Milestone
lifecycle 0.17.0

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Feb 2, 2023 •
edited

Spec PR: https://github.com/buildpacks/spec/pull/347/files

The restorer:

  - MUST resolve `run-image.reference` to a digest in `<analyzed>` if not present
  - MUST populate `run-image.target` data in `<analyzed>` if not present
  - **If** `<analyzed>` has `run-image.extend = true`, the lifecycle:
    - MUST download from the registry and save in OCI layout format the `run-image` in `<analyzed>` to `<kaniko-dir>/cache`
This was referenced Feb 2, 2023
Open
Closed
@natalieparellano natalieparellano added this to the lifecycle 0.17.0 milestone Feb 6, 2023
@natalieparellano
Copy link
Member Author

We may only need the image manifest and config (like for build image extension). Will confirm as part of #998

@natalieparellano
Copy link
Member Author

Edit: actually I don't think we need -generated, as analyzed.toml has all the info we need.

@natalieparellano natalieparellano mentioned this issue Feb 17, 2023
Merged
@natalieparellano natalieparellano self-assigned this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natalieparellano natalieparellano

Labels
status/ready type/enhancement New feature or request
Projects
None yet
Milestone
lifecycle 0.17.0
Development

Successfully merging a pull request may close this issue.

Restorer changes for run image extension buildpacks/lifecycle
1 participant
@natalieparellano