-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fully qualified image names (podman compatibility) #1218
Comments
Not only |
I like this suggestion although I know there will be some necessary discussion about ease-of-use considering that there's a large number of users that are coming from the docker CLI where the host is assumed if missing. |
changing: pack/internal/config/config.go Line 130 in 88c3455
would not be visible end-user facing. So at least for that part, no ease-of-use consideration would be necessary? Updating the docs so that all examples include the host might be different. I do not want to suggest to enforce only accepting image names that contain the host. |
@FlorianLudwig I would say that we are on the same page.
|
I'm thinking about giving it a try. |
@hhiroshell it would be great to get your help on this! Re the label, we flagged this issue for a Contribfest session that we hosted at KubeCon EU, but the issue is still up for grabs. |
Thanks @natalieparellano, so could you please assign this to me? |
Now, I'm working on fixing documentation at buildpacks/docs#702. |
To the reviewers, The document is now ready for review. I apologize for the relatively large pull request, as the entire document has been revised. |
Completed for works no the codes. |
Description
For podman compatibility (and more) it would be good to use fully qualified image names ( = include registry in image name)
Example: Instead of:
use:
Changes
Additional context
See also:
The text was updated successfully, but these errors were encountered: