Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate suggested builders from trusted default builders #1500

Closed
joshwlewis opened this issue Aug 17, 2022 · 2 comments · Fixed by #2043
Closed

Separate suggested builders from trusted default builders #1500

joshwlewis opened this issue Aug 17, 2022 · 2 comments · Fixed by #2043
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Milestone

Comments

@joshwlewis
Copy link
Member

joshwlewis commented Aug 17, 2022

Description

Currently, the suggested builder list has two functions that I am aware of: 1) it's the output of pack builder suggest and 2) it's the list of builders that are trusted by default.

This poses a difficulty for a vendor who wants a builder that is trusted by default, but would rather not suggest it to developers.

In my case, Heroku has a builder called heroku/builder-classic:22. This is a builder with shimmed Heroku V2 buildpacks. It's useful for folks who need some of the legacy language features from our V2 buildpacks, but since these are shimmed CNBs, we hardly think the builder should be recommended for general use.

Another use case is retiring builders. At some point in the future, we'll want to retire heroku/buildpacks:20. At that point, we'd like to stop suggesting it to new users, but it should probably be trusted by default up until most folks stop using it.

Proposed solution

Separate lists for "suggested" builders and "trusted by default" builders. The lists might have many of the same entries at first, but each could change independently over time.

Describe alternatives you've considered

The suggested builder list could be a subset of the trusted by default (or just trusted) list.

@joshwlewis joshwlewis added status/triage Issue or PR that requires contributor attention. type/enhancement Issue that requests a new feature or improvement. labels Aug 17, 2022
@dfreilich
Copy link
Member

Interesting use case! I definitely think it makes sense. The lists represent different things and should be disjoint.

We'd welcome a PR to make it happen!

@natalieparellano natalieparellano added status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Oct 12, 2022
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Aug 21, 2023
@natalieparellano natalieparellano added this to the 0.33.0 milestone Nov 13, 2023
@natalieparellano
Copy link
Member

Now that suggested builders contain extensions (see buildpacks/community#244) and extensions can't be used with the trusted flow, this would be even more useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants