-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC #0109] pack builder create
should accept builder env config
#1632
Comments
Tagging as "good first issue" as the implementation will borrow heavily from what already exists for translating |
Hey @natalieparellano, I want to work on this issue. I am also looking to participate in LFX Mentorship so it will be a good mentorship issue for me so that I will also get familiar with the project. Can you please assign me? |
@bhavyastar I just assigned to you #1615, do you prefer to work on that one first? |
Apologies, this issue is actually blocked on the discussion that will establish the desired schema for builder.toml (and whether an RFC is necessary). Hopefully this could be sorted soon, in the meantime it's probably best to start in on another issue :) |
We still need to discuss about the schema for builder.toml should look it, let's bring this up in the next working group meeting |
|
We talked about this during the working group meeting today, the proposed solution looks good for everybody so, I will mark this ticket as ready to be implemented |
Updated |
i am interested in contributing to this issue & i have gone through the links provided above, but still i have left with few doubts
from the above quote i need to create files in dir
|
@WYGIN thank you for taking such a careful look at this! I will try to answer your questions below. I hope this is helpful - let us know if anything else is unclear.
For now, I don't think so. This aligns with how we handle other comparable config values (such as base image name).
I apologize for the vague requirements here. If I have this config: [[build.env]]
name = "MY_VAR"
value = "my-val"
suffix = "prepend"
delim = ":" Then I should get this file structure:
Correct - project.toml env vars go in
|
i am thinking about having [[build.env]]
name = "MY_VAR"
value = "my-value"
action = "prepend"
[[build.env]]
name = "MY_VAR"
value = ":"
action = "delim" because
[[build.env]]
name = "MY_VAR"
value = "prependValue"
suffix = "prepend"
delim = ":"
[[build.env]]
name = "MY_VAR"
value = "defaultValue"
suffix = "default"
[[build.env]]
name = "MY_VAR"
value = "appendValue"
suffix = "append"
delim = ";" the user expects the result should be apart from these i have the following doubts
|
Ah, I don't think we ever expect That said I'd be in favor of keeping the simpler syntax below, as it's less to type and also avoids introducing new concept/terminology
Nope, in fact lowercase names are perfectly valid :) We should just respect whatever is defined.
I guess they would do something like |
i created logic to add a layer to image with buildConfigEnv files in |
If you want to see this working end-to-end you could create a buildpack that prints out its environment. Then set |
Description
As per RFC 0109, files in
/cnb/build-config/env
will be translated to buildpack environment variables by the lifecycle.It would be nice if builder.toml exposed a way to create these files.
Proposed solution
Add a table to builder.toml:
that will be translated to files in
/cnb/build-config/env
bypack
duringpack builder create
.Describe alternatives you've considered
[[build.env]]
mirrors[[io.buildpacks.build.env]]
in project descriptor but we might also call it[[env]]
Proposed changes to the platform spec would introduce
[[run.image]]
to builder.toml.Additional context
This may benefit from a sub-team RFC.
cc @samj1912 @AidanDelaney
The text was updated successfully, but these errors were encountered: