-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rebase option to "retag" rather than replacing the target image #1748
Comments
Good point! I think we had previously discussed it, and decided against doing it at the moment, but it makes sense to want to tag it as a different tag, in order to test it out first. I wouldn't want to override the |
One open question - In Looking into the technical details, the core of the Given that, we'd welcome a PR, once we have a resolution about the UX of the tag flag! It should be as simple as:
|
Related RFC: https://github.com/buildpacks/rfcs/blob/main/text/0115-rebase-immutable-image-ref.md @joeybrown-sf any additional thoughts here? |
I think this is a reasonable request. In lifecycle, the For instance, in the following example we want to rebase the image The command to accomplish this is as follows:
I would probably recommend the same flag name for consistency. Pack build also has the previous-image flag. |
Hi @natalieparellano @dfreilich |
@Parthiba-Hazra that would be great! I will assign you |
@natalieparellano is there any thing you want share with me before diving on this enhancement, maybe something that can help to get with started? anyway I am going for this. |
@Parthiba-Hazra apologies for being slow to respond here - I'll discuss with @jjbustamante and one of us should get back early next week |
@natalieparellano yes sure, I opened a pr on this one, it does the result. I will need some review on that. |
Thank you @Parthiba-Hazra I will try to take a look on this and review it! |
Description
When you use
pack rebase
to patch an image, you don't always want to replace it directly in your registry.It would be great to have an optional parameter on the
rebase
command to retag to something else when rebasing. As of today we need to use Docker directly to clone the target image before rebasing, which isn't great as if anything bad happens during the rebase we'll have a duplicated image in the target registry.Proposed solution
Have a new optional
--tag
parameter on the rebase command that allows you to define the new tag to use when rebasing. Alternatively, maybe we can reuse the--publish
command so that if a full image name with tag is used this value is used?Describe alternatives you've considered
Using Docker to perform these operations (not great, cf. above).
Additional context
The text was updated successfully, but these errors were encountered: