Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sample apps with dockerfiles, hooks, etc #112

Closed
aemengo opened this issue Oct 7, 2021 · 5 comments · Fixed by #128
Closed

Create sample apps with dockerfiles, hooks, etc #112

aemengo opened this issue Oct 7, 2021 · 5 comments · Fixed by #128

Comments

@aemengo
Copy link
Contributor

aemengo commented Oct 7, 2021

In light of buildpacks/rfcs#173, sample applications should be created with these new buildpack constructs: App Specified Dockerfile, Hook TOML, etc.

@cmoulliard
Copy link

Is the following builder structure correct ?

Screenshot 2021-10-08 at 17 15 56

@sclevine @natalieparellano @aemengo

@natalieparellano
Copy link
Member

I think ext.toml should be extension.toml. I don't think build.ext.toml and launch.ext.toml are included in the RFC (they were just talked about).

@natalieparellano
Copy link
Member

Please see buildpacks/lifecycle#709 (comment) for an initial take on this issue.

@cmoulliard
Copy link

(they were just talked about).

I saw them from a comment of Javier Romero. will remove them and add also run.Dockerfile and build.Dockerfile

@cmoulliard
Copy link

Structure updated

Screenshot 2021-10-08 at 18 24 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants