Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC 100] Deprecate positional args to build and detect in favor of env vars #294

Closed
mboldt opened this issue Mar 2, 2022 · 2 comments · Fixed by #295
Closed

[RFC 100] Deprecate positional args to build and detect in favor of env vars #294

mboldt opened this issue Mar 2, 2022 · 2 comments · Fixed by #295
Milestone
Buildpack 0.8

Comments

@mboldt
Copy link
Contributor

mboldt commented Mar 2, 2022

In RFC 100, there are buildpack spec changes to deprecate positional arguments to build and detect and instead pass those values in through environment variables.

The RFC is approved and merged, but it looks like the spec changes haven't made it into an issue yet.

Could we include this in buildpack api 0.8?

I am working on the related changes to lifecycle (buildpacks/lifecycle#806, buildpacks/lifecycle#807).

Happy to provide a PR.
@hone hone added this to the Buildpack 0.8 milestone Mar 2, 2022
@hone
Copy link
Member

hone commented Mar 2, 2022

@mboldt from core sub-team sync I've added this into the Buildpack 0.8 milestone. We'd be happy to take a PR. thanks! <3 <3

@mboldt mboldt mentioned this issue Mar 3, 2022
Merged
@natalieparellano natalieparellano linked a pull request Mar 15, 2022 that will close this issue
Deprecate positional args to build and detect and add env vars #295
Merged
@ekcasey
Copy link
Member

ekcasey commented Mar 30, 2022

Resolved by #295

@ekcasey ekcasey closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Buildpack 0.8
Development

Successfully merging a pull request may close this issue.

Deprecate positional args to build and detect and add env vars
3 participants
@hone @ekcasey @mboldt