-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Geyser Version Dependency #25
Comments
Not sure if this has anything to do with this but i'll put it here anyway |
I believe this is an issue because geyserreversion needs to support bedrock v422 |
This was resolved through reflection but I'll have a look at the link tonight to see what the issue may be. |
I might leave this open as even today I had to make a breaking change with GeyserCommand changing syntax. I'm not sure how important it is that this supports multiple versions of Geyser but I can see future issues when people are running multiple forks of Geyser where some forks have future features OR when GeyserReversion does not yet support the latest Geyser. May need to think about how to abstract this out in a module system but since Geyser doesn't use versions we'll need reflection to autodetect when to do what. |
Wouldn't it be easier and more universally useful to write to the protocol version and not to a Geyser commit? Geyser is undergoing rapid development, but the common goal is support for a (or a few) protocol versions. |
Closing this but just a note that I am indeed going to start a new project just dealing with protocol conversion likely as a proxy that sits in front of Geyser (or indeed bedrock itself). |
Ideally one should be able to drop GeyserReversion into any version of Geyser and it should just "work". However presently some changes in Geyser will break GeyserReversion as seen in GeyserMC/Geyser#1640 with a simple fix in #24
A fix is:
The text was updated successfully, but these errors were encountered: