This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Outdated] Support --group with the second group for a dependency #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bundlerbot r+ |
|
📌 Commit cec3f58 has been approved by |
|
⌛ Testing commit cec3f58 with merge 2ae3086... |
bundlerbot
added a commit
that referenced
this pull request
Oct 25, 2017
…dale [Outdated] Support --group with the second group for a dependency ### What was the end-user problem that led to this PR? The problem was `bundle outdated --group NAME` wouldn't work if it was the second group for the dependency. Closes #6115. ### What was your diagnosis of the problem? My diagnosis was we were joining with `, ` and splitting on `,`, so subsequent groups had an additional space.
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was
bundle outdated --group NAMEwouldn't work if it was the second group for the dependency.Closes #6115.
What was your diagnosis of the problem?
My diagnosis was we were joining with
,and splitting on,, so subsequent groups had an additional space.