You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but colors are always set using integer between [0:255]
why do we have to ask the user for a float and then change it 🧐
Can't we use whol numbers from 0 to 255 do the computation for the API and then return the appropriate value for the user ?
You see what I mean?
Btw: that's a breaking change 😛
a new method to set the color of a tab, something like: set_tab_color(hex_color) that takes only a color as hex value
a new function in utils.py that can convert a color from 3 arguments to a hex value: convert_colors_to_hex_value(red, gree, blue) this > way a user can use it 2 in ways seamlessly:
using direct argument assignment: ..._hex_value(123,43,12)
using named arguments: ..._hex_value(red=123, green=43, blue=12)
The text was updated successfully, but these errors were encountered:
There are many problems with how colors are currently set/read. See #1199.
The main issue is that if you send a color of
0.5
to Google, the color is set to0.49803922
(closest 8-bit value).This issue proposes that we change how colors are implemented to align to this 8-bit-ness.
old
new
unsure which of these is best
More discussion in #1199
The text was updated successfully, but these errors were encountered: