-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme with v6.0.0 migration guide #1279
Comments
breaking changes:
|
we should also
(should we?) |
sure that's a good one once we add the documentation. I started working on the first half of the documentation. I'll open a pr now. |
I have ticked the boxes above that we have implemented into the guide. For the others, I have comments:
I don't think this is needed in a migration guide. It is not a change, but an addition. i.e., in v5 people created a client with
Again, I don't think this is needed, as it is an addition. Additions can be viewed in the Release notes. Migration guide is only for breaking changes.
I don't know what this means
We went back on forcing the Drive API on people #1291. Thus, they no longer need to enable it.
This is not yet implemented |
With #1333, there is a deprecation warning for each tick in the above list. Now, we should ensure there is a deprecation warning in place before ticking an above item. |
We have an open issue about rewriting the sort method signature, to better type the arguments. #1090 but I think we can't do much about it.
|
last fix to apply on release_6_0_ is the sort method signature change, we don't need a mention in the migration guide, I ran the tests and everything works like before. the method signature has not changed much though but it's slightly better I believe. |
after this we should close this issue everything will be done. |
Overview
Update the main readme with a new temporary section with guidelines for migrating to v6.0.0
The text was updated successfully, but these errors were encountered: