Skip to content

Commit

Permalink
fix up the nonprod warning banner (#1397)
Browse files Browse the repository at this point in the history
it looks better at the very top, doesn't need a <p>, and
looks better on mobile without the emojis
  • Loading branch information
srabraham authored Nov 12, 2024
1 parent 01f8d45 commit 6844f78
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 1 addition & 4 deletions src/ims/element/_element.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,7 @@ def deployment_warning(
if deployment == "prod":
return ""
return tag(
tags.p(
f"☢️ This is not production. "
f"You are on a {deployment} IMS server. ☢️"
)
f"This is not production. You are on a {deployment} IMS server."
)

##
Expand Down
5 changes: 2 additions & 3 deletions src/ims/element/page/nav/template.xhtml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<!DOCTYPE html>
<nav xmlns:t="http://twistedmatrix.com/ns/twisted.web.template/0.1" t:render="root" class="navbar navbar-default">

<div class="nonprod-warning text-center" t:render="deployment_warning"></div>

<div class="navbar-header">
<button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#main-navbar" aria-expanded="false">
<span class="sr-only">Toggle navigation</span>
Expand Down Expand Up @@ -48,7 +50,4 @@

</div>

<div class="nonprod-warning text-center" t:render="deployment_warning">
</div>

</nav>

0 comments on commit 6844f78

Please sign in to comment.