Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests #15

Open
burtonjosh opened this issue Feb 15, 2024 · 1 comment
Open

Broken tests #15

burtonjosh opened this issue Feb 15, 2024 · 1 comment

Comments

@burtonjosh
Copy link
Owner

Current tests are broken, needs fixing

@burtonjosh
Copy link
Owner Author

One test comparing the output from an old python implementation (which is arguably not super reliable) is quite broken (marked with @test_broken in #16). The only change I can think of that would have caused this is updates to the solvers or MethodOfSteps.

Would be nicer to have some lower level tests checking functionality of the filter at each step. That would help with future debugging, since now it's not clear what goes wrong when a change is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant