Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import x-terminal to fix GitHub Searches into project #8

Closed
the-j0k3r opened this issue Feb 25, 2020 · 38 comments
Closed

Import x-terminal to fix GitHub Searches into project #8

the-j0k3r opened this issue Feb 25, 2020 · 38 comments
Labels
bug report 🐛 When something isn't working external 📤 This issue is external to the project

Comments

@the-j0k3r
Copy link
Member

the-j0k3r commented Feb 25, 2020

Currently if you search on this project for anything you get 0 hits, Forked projects dont get any searches, none.

Capture

If the repo is imported/ instead of forked this isnt a problem see https://github.com/the-j0k3r/x-terminal-fork-fix-gh-project-search/search?q=test&unscoped_q=test

Capture

👍 🎉

To do this goto Create a new repo and select import at the top

generic

Nothing is lost then simply making transition from one to other should be seamless.

An alternative way is to create a new empty repo and add a remote and rebase also very doable.

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Feb 25, 2020

Also I can just transfer my import of this to you, it saves you the work, just need to rename the project after you remove this one.

Edit Ive initiated this transfer to you =)

Or alternatively transfer to bus-stop org where you can admin/dev it there.

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

I think it would be best to transfer it to bus-stop. Do you know if there is a way to change the repository but keep the package name on atom?

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

It looks like if I just transfer the repo to bus-stop the upstream fork will remain. https://flight-manual.atom.io/behind-atom/sections/maintaining-your-packages/#transferring-ownership

I wonder if it would work to rename the repo, import it into the same name (UziTech/x-terminal), then transfer it?

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Feb 25, 2020

I can export directly to bus-stop with x-terminal name, I simply rename it to x-terminal and transfer.

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

yes but will APM allow you to publish from the new repo?

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Feb 25, 2020

Yes, Termination was imported into bus-stop, besides readme links nothing else changed.

I think you can even yourself export it to bus-stop directly, its the same procedure as above, I imported into my own account not the org as I wasnt sure if thats was OK with you.

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

But if I transfer it how it is right now the upstream fork will remain according to https://help.github.com/en/github/administering-a-repository/transferring-a-repository

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Feb 25, 2020

You dont transfer it, you import it ;) Goto https://github.com/organizations/bus-stop/repositories/new and on the next page on the top

Create a new repository

A repository contains all project files, including the revision history. Already have a project repository elsewhere? Import a repository.

No upstream fork will be marked just like in my test import instance

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

I imported it to bus-stop. https://github.com/bus-stop/x-terminal

I'll try publishing a new version with the new repo

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

I don't think there is a way to make APM look for the package at the new repo without transferring it.

@the-j0k3r
Copy link
Member Author

It worked for Termination...

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

I renamed it imported and transfered it. hopefully that works

@the-j0k3r
Copy link
Member Author

Seems like its working OK building at least.

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

ya and now the repo link on atom.io goes to bus-stop

@the-j0k3r
Copy link
Member Author

You beat me to it.

@UziTech
Copy link
Member

UziTech commented Feb 25, 2020

looks like actions is failing to push the new tag to APM

Git tag not found

Maybe APM just needs time to update it's cache?

@the-j0k3r
Copy link
Member Author

Capture

Seems fully updated, I received 8.0.2 and it points all to bus-stop, Maybe it needed time to spread.

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Feb 26, 2020

Mk log for https://github.com/bus-stop/x-terminal/runs/469502934?check_suite_focus=true says

The local branch master is behind the remote one, therefore a new version won't be published

You may want to check that remote is not set to this repo or something else, since 8.0.3 is not on offer yet.

Edit: my query shows only the expected

origin  https://github.com/bus-stop/x-terminal.git (fetch)
origin  https://github.com/bus-stop/x-terminal.git (push)

I also rerun the workflows on the failed actions, all are green now.

@the-j0k3r
Copy link
Member Author

Im also wondering about the semantic release bot, doesn't it have to be installed in project?

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

it is installed as a devdependency

@the-j0k3r
Copy link
Member Author

Well idk why it wont publish 8.0.3

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

seems like it is a common issue with APM atom/apm#873

looks like we need an admin to change the repo on their server.

@the-j0k3r
Copy link
Member Author

looks like we need an admin to change the repo on their server.

admin to what?

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

admin to atom.io

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

atom/apm#870 (comment)

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Feb 26, 2020

Im perplexed. Termination was done under same circumstances, except it not running automated releases or actions. See https://github.com/bus-stop/Termination/commits/master it was as simple as that. Zero issues with this.

have you tried a manual release via apm publish? I think that may just do it. ™️ famous last words worth a shot maybe.

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

same error when trying to publish manually

image

@the-j0k3r
Copy link
Member Author

hummmm bum! Those failed tags are published though shouldt they be deleted?

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

I was able to publish v8.0.4 but only after pushing tags to this repo. atom.io's system must use some sort of repo ID instead of path.

That means I could transfer this repo to bus-stop/xterminal but the upstream fork would remain. 😕

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

looks like we just need to contact support to remove fork.

https://git.luolix.topmunity/t5/How-to-use-Git-and-GitHub/De-forking-a-Github-repo/td-p/2785

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

I'm going to delete bus-stop/x-terminal then transfer this repo and contact support to remove the fork

@the-j0k3r
Copy link
Member Author

I guess Ill stop what Im doing then

@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

boom 🎉 Actions released v8.0.5 😁👍

@UziTech UziTech closed this as completed Feb 26, 2020
@the-j0k3r
Copy link
Member Author

Yea it was the setup thingy

@the-j0k3r
Copy link
Member Author

yep this issue is not fixed though

@the-j0k3r the-j0k3r reopened this Feb 26, 2020
@UziTech
Copy link
Member

UziTech commented Feb 26, 2020

true. I submitted a request to remove the upstream fork.

@the-j0k3r
Copy link
Member Author

I would have thought fixing atom.io would have been more likely, lets see =)

@the-j0k3r the-j0k3r added bug report 🐛 When something isn't working external 📤 This issue is external to the project labels Feb 27, 2020
@the-j0k3r
Copy link
Member Author

Seems fixed... That was fast... hopefully releasing still works.

@bus-stop bus-stop locked as resolved and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug report 🐛 When something isn't working external 📤 This issue is external to the project
Development

No branches or pull requests

2 participants