feat: async iterate readable streams, iterate function
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- async iterator on all bluestream readable streams - `iterate(stream)` any readable stream BREAKING CHANGE: dropped the default export
tsiege
reviewed
May 2, 2018
| import { Readable } from 'stream' | ||
| import { readAsync } from '.' | ||
|
|
||
| if ((Symbol as any).asyncIterator === undefined) { |
There was a problem hiding this comment.
This is the syntax that's confusing me the most.
There was a problem hiding this comment.
this is a polyfill for the asyncIterator symbol, since the type Symbol doesn't have that property we need to cast it to an any to get it pass lint
tsiege
reviewed
May 2, 2018
| throw new TypeError('"stream" is in flowing mode, this is probably not what you want as data loss could occur. Please use stream.pause() to pause the stream before calling readAsync.'); | ||
| } | ||
|
|
||
| const inflightRead = inflightReads.get(stream) |
There was a problem hiding this comment.
this is some sort of buffer?
There was a problem hiding this comment.
Yeah, it defers next readAsync until after the first one finishes so they don't clobber. The weakmap keys the inflight reads on the stream objects themselves and doesn't cause a memory leak like a normal Map would.
tsiege
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterate(stream)any readable streamBREAKING CHANGE: dropped the default export