Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Grid API redesign #1301

Closed
wuweiweiwu opened this issue Jan 5, 2019 · 1 comment
Closed

WIP: Grid API redesign #1301

wuweiweiwu opened this issue Jan 5, 2019 · 1 comment

Comments

@wuweiweiwu
Copy link
Contributor

wuweiweiwu commented Jan 5, 2019

Reconsidering the Grid api and implementation with the goal of least amount of churn

Current api:

https://github.com/bvaughn/react-virtualized/blob/master/docs/Grid.md

New api / todos:

  • clear scrollTo{row,col} and scroll{left,top} after scroll, or if another one is set
  • determine which of the ^ takes precedence
  • fix internal gDSFP implementation
  • use the profiler to identify bottlenecks
  • make grid uncontrollable and update via instance methods
  • new way to find index of dynamic rows / column. keep running sum and binary search scrollLeft or top
@wuweiweiwu
Copy link
Contributor Author

closing in favor of #1461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant