Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outwards order for expensive cells? #645

Closed
Izhaki opened this issue May 18, 2022 · 0 comments
Closed

Outwards order for expensive cells? #645

Izhaki opened this issue May 18, 2022 · 0 comments

Comments

@Izhaki
Copy link

Izhaki commented May 18, 2022

The order of the columns is left to right, and rows top to bottom.

We are using the virtualiser to render audio waveforms and their overview takes time to calculate. What's more, this will eventually happen in web workers, meaning asynchronously.

For example, each column will 1000px wide. At zoom 1/32 you have 32000 samples to iterate on, per column. With an overscan of 1, this gives nearly 100K samples on initial render.

It makes more sense in these scenarios to first render the column that is actually seen, only then do the overscan ones.

In fact, I think this makes sense for all cases.

@bvaughn bvaughn closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants