Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: positional-only argument in method of class #90

Closed
cgahr opened this issue May 1, 2023 · 1 comment · Fixed by #108
Closed

Bug: positional-only argument in method of class #90

cgahr opened this issue May 1, 2023 · 1 comment · Fixed by #108
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cgahr
Copy link
Collaborator

cgahr commented May 1, 2023

In _method_requirements.py the function def _get_method_requirements_for_function_def(...): ... contains a bug.

The following class using positional-only arguments is not parsed correctly:

class C:
    def fun(self, arg0, /, arg1):
        ...

If I understand the code correctly, in this case the name of the self argument is not parsed correctly.

@cgahr cgahr changed the title Bug: positionl-only argument in method of class Bug: positional-only argument in method of class May 1, 2023
@bwhmather bwhmather added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 3, 2023
@bwhmather
Copy link
Owner

Does that mean the result of def _get_method_requirements_for_function_def(...): currently includes self? If so, I think that your assessment is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants