This repository has been archived by the owner on Apr 9, 2023. It is now read-only.
Use absolute imports #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #15 +/- ##
=======================================
Coverage 2.22% 2.22%
=======================================
Files 6 6
Lines 45 45
Branches 9 9
=======================================
Hits 1 1
Misses 35 35
Partials 9 9
|
byCedric
pushed a commit
that referenced
this pull request
Oct 13, 2018
# [0.1.0](0.0.0...0.1.0) (2018-10-13) ### Bug fixes * allow package scope for greenkeeper only ([#24](#24)) ([0623aa4](0623aa4)) * remove package lock file from project for greenkeeper ([#25](#25)) ([5963734](5963734)) ### Code refactors * move app component to pages folder using atomic design ([52d5c8c](52d5c8c)) * move global styles to html template ([fa7911c](fa7911c)) * move logo to static assets folder ([b570b24](b570b24)) * move semantic release config to dedicated file ([#13](#13)) ([4dc4eae](4dc4eae)) * rename service worker to use lower case for imports ([2341c0b](2341c0b)) * separate index to react and sw providers ([838e25c](838e25c)) * use absolute imports to make imports predictable ([#15](#15)) ([d031a7c](d031a7c)) * use npm instead of yarn ([9d9f1a3](9d9f1a3)) * use tabs for indentation and spaces for alignment ([#23](#23)) ([eecdb00](eecdb00)) ### Documentation changes * add greenkeeper badge ([#11](#11)) ([09c94df](09c94df)) * emphasise on github showing your public events ([#26](#26)) ([e169bd0](e169bd0)) * rewrite readme to match project ([#10](#10)) ([34d6d9f](34d6d9f)) * use bright green color in greenkeeper badge ([4c3205c](4c3205c)) ### New features * add github user components ([#28](#28)) ([94fd537](94fd537)) ### Other chores * add github templates for easy contributions ([#2](#2)) ([c6724af](c6724af)) * add shared editor configuration ([0c23899](0c23899)) ### Pipeline changes * add codecov comments in pull requests ([#6](#6)) ([821ead7](821ead7)) * add codecov to test coverages per pull request ([#4](#4)) ([f2f1adf](f2f1adf)) * add commitlint to travis to make predictable releases ([#5](#5)) ([1bbe228](1bbe228)) * add eslint to travis ci ([#7](#7)) ([d4e90c7](d4e90c7)) * add flow to travis ci as replacement for proptypes ([#17](#17)) ([584fe1d](584fe1d)) * add most basic travis configuration for ci ([#3](#3)) ([7ed5796](7ed5796)) * add semantic release to travis for predictable releases ([#12](#12)) ([c2c9b79](c2c9b79)) * add stylelint to help detecting bad usage ([#16](#16)) ([bd32bc2](bd32bc2)) * configure greenkeeper to use conventions ([#8](#8)) ([e6d6d7f](e6d6d7f)) * use simplified http repository url for travis and semantic release ([43e9937](43e9937))
|
🎉 This PR is included in version 0.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
none, part of initial setup
Additional context
Personally, I don't like having to think about how many
../I need to use to import something. Having absolute imports make these things cleaner and predictable. SettingNODE_PATHto project root, instead of./srcis intentional.Having
./srcmakes it visually less distinctive compared to normal plugins, e.g.Adding the
srcmakes it a bit more distinctive, e.g.I'm also kind of 99.9% positive that there won't, or at least shouldn't, be a library called
src. So name collision is out of the question.