This repository has been archived by the owner on Apr 9, 2023. It is now read-only.
feature: github mentions support as a component #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just notice I could refactor the highlighter to include a decorator component for hyperlinks for the '@' mentions, would you like to have support for this? I think it would make it a lot easier for people visiting your portfolio Github Website to explorer all the companies and people you mention. @byCedric |
|
@ItsWendell Yes, I did not implement this yet because of some separation of concerns I couldn't quickly figure out. The user molecule should have no references to GitHub whatsoever, but it should be styled there since all styling should go into that molecule. Let's talk about it when I get back from ADE. 😄 |
Codecov Report
@@ Coverage Diff @@
## develop #56 +/- ##
========================================
- Coverage 57.42% 50% -7.43%
========================================
Files 21 23 +2
Lines 101 116 +15
Branches 15 18 +3
========================================
Hits 58 58
- Misses 34 46 +12
- Partials 9 12 +3
|
byCedric
pushed a commit
that referenced
this pull request
Dec 1, 2018
# [0.4.0](0.3.1...0.4.0) (2018-12-01) ### Code refactors * move user description highlights to github user organism ([#68](#68)) ([2575cec](2575cec)) * remove superseded github mentions ([#84](#84)) ([5e9e513](5e9e513)) * upgrade now to version 12.0.0 ([#74](#74)) ([3878702](3878702)) * upgrade react-scripts to version 2.1.0 ([#73](#73)) ([74e8974](74e8974)) * user molecule layout to allow other content ([#63](#63)) ([d1ad708](d1ad708)) ### Documentation changes * add notice about deployments with now v2 ([#83](#83)) ([167a5f3](167a5f3)) ### New features * implement mention link in user molecule ([#65](#65)) ([0a0cb92](0a0cb92)) * prototype github mentions support as a component ([#56](#56)) ([1788b32](1788b32)) * upgrade to now version 2 ([#79](#79)) ([f97f7ab](f97f7ab)) ### Pipeline changes * escape stylelint file glob ([#64](#64)) ([0cc473f](0cc473f)) * limit node versions because of unexpected fetch behaviour ([#82](#82)) ([eb50a5f](eb50a5f)) * test full build in travis to detect feature issues with cra ([#85](#85)) ([5592f94](5592f94)) * upgrade travis with auto-release and security checks ([#81](#81)) ([da79f78](da79f78)) ### Testing updates * add extra tests to atom components ([#67](#67)) ([41d746c](41d746c)) * add extra tests to github provider ([#66](#66)) ([14d6efa](14d6efa)) * add unit tests for github user organism ([#70](#70)) ([4023dc1](4023dc1)) * add unit tests for user molecule ([#69](#69)) ([84eb513](84eb513)) * clean up dirty tests and add app page component test ([#71](#71)) ([addb123](addb123))
byCedric
pushed a commit
that referenced
this pull request
Dec 1, 2018
# [0.4.0](0.3.1...0.4.0) (2018-12-01) ### Code refactors * move user description highlights to github user organism ([#68](#68)) ([2575cec](2575cec)) * remove superseded github mentions ([#84](#84)) ([5e9e513](5e9e513)) * upgrade now to version 12.0.0 ([#74](#74)) ([3878702](3878702)) * upgrade react-scripts to version 2.1.0 ([#73](#73)) ([74e8974](74e8974)) * user molecule layout to allow other content ([#63](#63)) ([d1ad708](d1ad708)) ### Documentation changes * add notice about deployments with now v2 ([#83](#83)) ([167a5f3](167a5f3)) ### New features * implement mention link in user molecule ([#65](#65)) ([0a0cb92](0a0cb92)) * prototype github mentions support as a component ([#56](#56)) ([1788b32](1788b32)) * upgrade to now version 2 ([#79](#79)) ([f97f7ab](f97f7ab)) ### Pipeline changes * escape stylelint file glob ([#64](#64)) ([0cc473f](0cc473f)) * limit node versions because of unexpected fetch behaviour ([#82](#82)) ([eb50a5f](eb50a5f)) * test full build in travis to detect feature issues with cra ([#85](#85)) ([5592f94](5592f94)) * upgrade travis with auto-release and security checks ([#81](#81)) ([da79f78](da79f78)) ### Testing updates * add extra tests to atom components ([#67](#67)) ([41d746c](41d746c)) * add extra tests to github provider ([#66](#66)) ([14d6efa](14d6efa)) * add unit tests for github user organism ([#70](#70)) ([4023dc1](4023dc1)) * add unit tests for user molecule ([#69](#69)) ([84eb513](84eb513)) * clean up dirty tests and add app page component test ([#71](#71)) ([addb123](addb123))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
Fixes #50
Note
I know you just already merged a PR for this, could you still rate / review it?