Skip to content
This repository has been archived by the owner on Apr 9, 2023. It is now read-only.

Fix/GitHub keywords #62

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Fix/GitHub keywords #62

merged 2 commits into from
Oct 18, 2018

Conversation

byCedric
Copy link
Owner

Linked issue

I've noticed some issues with findKeywords when no keywords were found. This should fix it.

@byCedric byCedric added the bug Something isn't working label Oct 18, 2018
@byCedric byCedric added this to the 1.0.0 milestone Oct 18, 2018
@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #62 into develop will increase coverage by 4.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #62     +/-   ##
=========================================
+ Coverage     4.23%   8.54%   +4.3%     
=========================================
  Files           22      22             
  Lines          118     117      -1     
  Branches        12      12             
=========================================
+ Hits             5      10      +5     
+ Misses         101      97      -4     
+ Partials        12      10      -2
Impacted Files Coverage Δ
src/providers/github.js 71.42% <100%> (+71.42%) ⬆️

@byCedric byCedric merged commit 67bacbe into develop Oct 18, 2018
@byCedric byCedric deleted the fix/github-keywords branch October 18, 2018 13:56
byCedric pushed a commit that referenced this pull request Oct 18, 2018
## [0.3.1](0.3.0...0.3.1) (2018-10-18)

### Bug fixes

* return empty array when no github keywords are found ([#62](#62)) ([67bacbe](67bacbe))
@byCedric
Copy link
Owner Author

🎉 This PR is included in version 0.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant