Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin ubuntu to 22.04, to fix maturin publication action #590

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

akotlar
Copy link
Collaborator

@akotlar akotlar commented Oct 13, 2024

Summary by CodeRabbit

  • Chores
    • Updated the GitHub Actions workflow to use ubuntu-22.04 for Linux jobs, enhancing compatibility and performance.

Copy link
Contributor

coderabbitai bot commented Oct 13, 2024

Walkthrough

The changes involve updates to the GitHub Actions workflow configuration for Python releases. Specifically, the runner version for the Linux jobs (linux, sdist, and release) has been changed from ubuntu-latest to ubuntu-22.04. The macOS job configurations remain unchanged, continuing to support both macos-12 and macos-14. The overall structure of the workflow is preserved, with no modifications to the execution steps or commands.

Changes

File Path Change Summary
.github/workflows/python-release.yml Updated job runners from ubuntu-latest to ubuntu-22.04 for jobs: linux, sdist, release.

Poem

In the land of code, where rabbits play,
We updated our runners, hip-hip-hooray!
From latest to twenty-two-four,
Our workflows now hop with a little more roar!
With macOS still in the game,
We celebrate progress, never the same! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 52779e0 and 063e043.

📒 Files selected for processing (1)
  • .github/workflows/python-release.yml (3 hunks)
🧰 Additional context used
🔇 Additional comments (4)
.github/workflows/python-release.yml (4)

27-27: Approved: Pinning Ubuntu version improves stability

This change from ubuntu-latest to ubuntu-22.04 aligns with the PR objective and offers several benefits:

  1. It provides better stability and reproducibility by using a specific Ubuntu version.
  2. It may resolve issues with the maturin publication action, as mentioned in the PR title.
  3. It ensures consistent behavior across different runs of the workflow.

145-145: Approved: Consistent Ubuntu version across jobs

The change to ubuntu-22.04 for the sdist job:

  1. Maintains consistency with the linux job, ensuring a uniform environment across different stages of the workflow.
  2. Aligns with the PR objective of pinning Ubuntu to a specific version.
  3. Contributes to resolving potential issues with the maturin publication action.

161-161: Approved: Consistent environment for release job

Updating the release job to use ubuntu-22.04:

  1. Ensures consistency across all jobs in the workflow (linux, sdist, and release).
  2. Provides a stable and predictable environment for the critical release step.
  3. Directly addresses the PR objective of fixing the maturin publication action by using a specific Ubuntu version.

This change completes the pinning of Ubuntu to 22.04 throughout the workflow, which should resolve the issues mentioned in the PR title.


27-27: Summary: Successful implementation of Ubuntu version pinning

The changes in this PR consistently update the Ubuntu version from ubuntu-latest to ubuntu-22.04 across all relevant jobs (linux, sdist, and release). This implementation:

  1. Fully addresses the PR objective of pinning Ubuntu to 22.04.
  2. Provides a stable and reproducible environment for all stages of the workflow.
  3. Should resolve the issues with the maturin publication action, as mentioned in the PR title.
  4. Maintains the overall structure and functionality of the workflow, with no other modifications.

These changes are well-implemented and should improve the reliability of the Python release process.

Also applies to: 145-145, 161-161


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@akotlar akotlar merged commit 3833aa0 into bystrogenomics:master Oct 13, 2024
12 checks passed
@akotlar akotlar deleted the bugfix/fix-maturin-sdist branch November 19, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant