Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Commit

Permalink
Update directory iteration APIs.
Browse files Browse the repository at this point in the history
  • Loading branch information
sunfishcode committed Dec 8, 2022
1 parent 9cae172 commit 37e2e16
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 26 deletions.
10 changes: 8 additions & 2 deletions host/src/filesystem.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,14 @@ impl wasi_filesystem::WasiFilesystem for WasiCtx {
fn readdir(
&mut self,
fd: wasi_filesystem::Descriptor,
rewind: bool,
) -> HostResult<Vec<u8>, wasi_filesystem::Errno> {
) -> HostResult<wasi_filesystem::DirEntryStream, wasi_filesystem::Errno> {
todo!()
}

fn read_dir_entry(
&mut self,
stream: wasi_filesystem::DirEntryStream,
) -> HostResult<wasi_filesystem::DirEntry, wasi_filesystem::Errno> {
todo!()
}

Expand Down
44 changes: 20 additions & 24 deletions wit/wasi.wit
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ interface wasi-filesystem {
/// A "file" descriptor. In the future, this will be replaced by handle types.
type descriptor = u32

/// A directory entry stream. In the future, this will be replaced by an
/// actual stream.
type dir-entry-stream = u32

/// Size of a range of bytes in memory.
type size = u32

Expand Down Expand Up @@ -318,13 +322,18 @@ interface wasi-filesystem {
}

/// A directory entry.
record dirent {
/// The serial number of the file referred to by this directory entry.
ino: inode,
/// The length of the name of the directory entry.
namelen: size,
record dir-entry {
/// The serial number of the object referred to by this directory entry.
/// May be none if the inode value is not known.
///
/// When this is none, libc implementations might do an extra `stat-at`
/// call to retrieve the inode number to fill their `d_ino` fields, so
/// implementations which can set this to a non-none value should do so.
ino: option<inode>,
/// The type of the file referred to by this directory entry.
%type: descriptor-type,
/// The name of the object.
name: string,
}

/// Error codes returned by functions.
Expand Down Expand Up @@ -610,25 +619,12 @@ interface wasi-filesystem {

/// Read directory entries from a directory.
///
/// TODO this shouldnt be a binary interface. Instead, define the struct
/// and whatever of its members are required here, and then return a list
/// of those structs. Delete the rewind argument.
///
/// When successful, the contents of the output buffer consist of a sequence of
/// directory entries. Each directory entry consists of a `dirent` object,
/// followed by `dirent::d_namlen` bytes holding the name of the directory
/// entry.
///
/// This function fills the output buffer as much as possible, potentially
/// truncating the last directory entry. This allows the caller to grow its
/// read buffer size in case it's too small to fit a single large directory
/// entry, or skip the oversized directory entry.
readdir: func(
/// The resource to operate on.
fd: descriptor,
/// If true, rewind the current position to the beginning before reading.
rewind: bool
) -> result<list<u8>, errno>
/// This always returns a new stream which starts at the beginning of the
/// directory.
readdir: func(fd: descriptor) -> result<dir-entry-stream, errno>

/// Read a single directory entry from a `dir-entry-stream`.
read-dir-entry: func(dir-stream: dir-entry-stream) -> result<dir-entry, errno>

/// Move the offset of a descriptor.
///
Expand Down

0 comments on commit 37e2e16

Please sign in to comment.