-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release a new "major"? #71
Comments
In fact, I'm a bit torn: it really is a new addition to the API, so as such shouldn't be considered a breaking change; but as a new variant in an enum that's not marked exhaustive, it'll break compilation for users who don't handle it manually (e.g. in |
Most of the enums in target-lexicon are marked Once that lands, I'll do a 0.12 release and yank 0.11.3. |
Ok, 0.12 is now up, and 0.11.3 is now yanked. |
Supersedes #1132, which was yanked in bytecodealliance/target-lexicon#71.
Supersedes #1132, which was yanked in bytecodealliance/target-lexicon#71. This PR relaxes the target lexicon version constraint to only specify the minor version.
Turns out that adding the aarch64 darwin calling convention in #70 is a breaking API change: in wasmtime, which targets 0.11 of this library, and thus uses the latest patch version, this causes an assertion failure that the calling convention is unknown, because it isn't properly handled yet (I'll take care of this). The same issue could happen to other target_lexicon users, so it might require a new "major" release of target-lexicon to indicate this breaking change happened.
Since this crate is still pre 1.0, a new "major" release consists in bumping what's otherwise the "minor" number, so it should be 0.12.
The text was updated successfully, but these errors were encountered: