Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure kebab case for identifiers #5

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

eduardomourar
Copy link
Collaborator

@eduardomourar eduardomourar commented Apr 11, 2023

As described in the WIT spec:

Identifiers in WIT documents are required to be valid component identifiers, meaning that they're "kebab cased". This currently is restricted to ascii characters and numbers that are - separated.

The logic that was added to the grammar can be simplified after a language server is available to check the linting rules.

@eduardomourar eduardomourar merged commit 7ec3057 into main Apr 12, 2023
@eduardomourar eduardomourar deleted the fix/identifier-kebab-case branch April 12, 2023 00:35
eduardomourar pushed a commit that referenced this pull request Apr 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.0.3](wit-idl-v0.0.2...wit-idl-v0.0.3)
(2023-04-12)


### Bug Fixes

* ensure kebab case for identifiers
([#5](#5))
([7ec3057](7ec3057))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

🎉 This change has been included in wit-idl-v0.0.3 🎉

The release is available on:

Your release-please bot 🚀🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant