Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for unsigned types in external functions #1829

Closed
olonho opened this issue Jun 5, 2020 · 3 comments
Closed

No support for unsigned types in external functions #1829

olonho opened this issue Jun 5, 2020 · 3 comments
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself

Comments

@olonho
Copy link

olonho commented Jun 5, 2020

When using Linker.func with function with signature fn(u64, u64) -> i32 get this error

the trait wasmtime::func::IntoFunc<_, _> is not implemented for fn(u64, u64) -> i32

It is important to use unsigned types in external functions in many cases.

@alexcrichton
Copy link
Member

I think this was added pretty recently in #1808, mind trying that out and seeing if that works for you?

@alexcrichton alexcrichton added the wasmtime:api Related to the API of the `wasmtime` crate itself label Jun 8, 2020
@github-actions
Copy link

github-actions bot commented Jun 8, 2020

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton
Copy link
Member

I believe this has since been added so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

No branches or pull requests

2 participants