-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cranelift: srem.8 and srem.i16 not supported #2826
Comments
Thanks for the report! I can take a look at some point, but I'm deep in a bunch of other stuff right now, so if you have some time and are willing to look at the lowering (I suspect it may just be a matter of using a narrower form), I'd be grateful and would be happy to review. The regalloc issue I think may have come from a recent PR from @abrown that touched |
Yeah, I can take a look. |
Previously, `Inst::store` only understood a subset of the scalar types, which resulted in failures seen in bytecodealliance#2826. This change allows `Inst::store` to generate instructions for all scalar widths (`8 | 16 | 32 | 64`) since all of these are supported in the emission code of `Inst::MovRM`.
Previously, `Inst::store` only understood a subset of the scalar types, which resulted in failures seen in bytecodealliance#2826. This change allows `Inst::store` to generate instructions for all scalar widths (`8 | 16 | 32 | 64`) since all of these are supported in the emission code of `Inst::MovRM`.
.clif
Test CaseSteps to Reproduce
Expected Results
Compiles
Actual Results
Versions and Environment
Cranelift version or commit: 67cc42d
Operating system: N/A
Architecture: x86_64
Extra Info
Likely introduced in #2763.
I also saw another error when trying to update Cranelift, but I haven't found a standalone repro yet:
The text was updated successfully, but these errors were encountered: