Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lightbeam] the lightbeam compiler doesn't work #3181

Closed
lei-april opened this issue Aug 12, 2021 · 4 comments
Closed

[lightbeam] the lightbeam compiler doesn't work #3181

lei-april opened this issue Aug 12, 2021 · 4 comments
Labels
bug Incorrect behavior in the current implementation that needs fixing

Comments

@lei-april
Copy link

Test Case

Example for C embedding from the official doc site: https://docs.wasmtime.dev/examples-c-hello-world.html

With a few changes to enable the lightbeam compiler:

48c48,50
<   wasm_engine_t *engine = wasm_engine_new();
---
>   wasm_config_t* config = wasm_config_new();
>   wasmtime_config_strategy_set(config, WASMTIME_STRATEGY_LIGHTBEAM);
>   wasm_engine_t *engine = wasm_engine_new_with_config(config);

Steps to Reproduce

Compile and run the above example, using wasmtime's main branch with lightbeam enabled.

Expected Results

The example runs correctly.

Actual Results

The compiler panics:

Initializing...
Compiling module...
thread '<unnamed>' panicked at 'not implemented', crates/lightbeam/wasmtime/src/lib.rs:224:9

Versions and Environment

Wasmtime version or commit: 44f9ccd

Operating system: Linux

Architecture: x86-64

@lei-april lei-april added the bug Incorrect behavior in the current implementation that needs fixing label Aug 12, 2021
@bjorn3
Copy link
Contributor

bjorn3 commented Aug 12, 2021

Lightbeam is unmaintained and has probably been broken for quite a while.

@lei-april
Copy link
Author

Lightbeam is unmaintained and has probably been broken for quite a while.

So is there any plan to fix it?

@bjorn3
Copy link
Contributor

bjorn3 commented Aug 13, 2021

Not that I am aware of.

@alexcrichton
Copy link
Member

Lightbeam was removed in #3390 as explained in RFC 14, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior in the current implementation that needs fixing
Projects
None yet
Development

No branches or pull requests

3 participants