Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cranelift-codegen's build.rs #3531

Closed
fitzgen opened this issue Nov 16, 2021 · 2 comments
Closed

Remove cranelift-codegen's build.rs #3531

fitzgen opened this issue Nov 16, 2021 · 2 comments
Labels
cranelift:goal:build-time Reduce the Rustc build time of Cranelift itself cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator enhancement

Comments

@fitzgen
Copy link
Member

fitzgen commented Nov 16, 2021

We should check in all generated code, since it doesn't change based on any user of cranelift-codegen's input or system or anything like that, and have a script that we can re-run as needed to regenerate these files. This will speed up compile times and remove cargo build time dependencies.

See also this thread #3506 (comment)

@cfallin
Copy link
Member

cfallin commented Nov 18, 2021

As noted in #3540, possibly a good way to go about this would be to maintain a small build.rs that just does a check for stale sources by comparing the meta-sources against a manifest, as #3534 does for ISLE. I think we should try to protect against this otherwise somewhat probable silent failure for new contributors; hopefully a build.rs that just uses sha2 and nothing else is relatively fast to compile :-)

@akirilov-arm akirilov-arm added cranelift Issues related to the Cranelift code generator cranelift:goal:build-time Reduce the Rustc build time of Cranelift itself cranelift:meta Everything related to the meta-language. enhancement labels Jan 26, 2022
@alexcrichton
Copy link
Member

Given the experience from #4066 it seems we're pretty unlikely to reverse direction at this point, so I'm going to close.

@alexcrichton alexcrichton closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:goal:build-time Reduce the Rustc build time of Cranelift itself cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator enhancement
Projects
None yet
Development

No branches or pull requests

4 participants