-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmtime-py doesn't build with cargo test
#468
Comments
Would this work? #[cfg(test)]
#[link(name = "python")]
extern "C" {} |
@bjorn3 Linking Python is not quite as simple as Apparently pyo3 documents this issue, and recommends disabling the extension-module feature when testing. Unfortunately, that would break things like |
Afaik the only proper solution to this problem would be introducing something like |
This was sinced moved to https://github.com/bytecodealliance/wasmtime-py, so closing. |
wasmtime-py uses pyo3's "extension-module" feature flag, which makes it not link libpython directly, so that it works in whatever python or libpython the address space already has loaded.
This seems perfectly reasonable, but as far as I can tell, that means that cargo test --package=wasmtime-py can't work, as it tries to link a binary. That link results in unresolved symbol errors for all the Python symbols.
@sunfishcode suggested filing this as an issue. cc @fitzgen and @alexcrichton.
The text was updated successfully, but these errors were encountered: