Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent argument handling between the run and serve commands #7105

Closed
elliottt opened this issue Sep 28, 2023 · 1 comment
Closed

Consistent argument handling between the run and serve commands #7105

elliottt opened this issue Sep 28, 2023 · 1 comment

Comments

@elliottt
Copy link
Member

I think it'd be best if this had similar options to wasmtime run, for example --allow-precompiled, --dir, --env, and --profile. That being said I think it's also totally ok for this to be a follow-up PR too.

One thing that I think should also be done is to share the code that configures WASI, e.g. processing many of the -S options. For example in theory wasi-nn and such should all be possible to enable too. That would require some refactoring, however, so perhaps best to open an issue and/or file a follow-up PR for that.

Originally posted by @alexcrichton in #7091 (comment)

@elliottt
Copy link
Member Author

elliottt commented Oct 4, 2023

Fixed in #7134

@elliottt elliottt closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant