Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64: WasmFault calculated with incorrect Wasm address #7624

Closed
abrown opened this issue Dec 1, 2023 · 1 comment
Closed

aarch64: WasmFault calculated with incorrect Wasm address #7624

abrown opened this issue Dec 1, 2023 · 1 comment
Labels
bug Incorrect behavior in the current implementation that needs fixing

Comments

@abrown
Copy link
Contributor

abrown commented Dec 1, 2023

Test Case

See wasm_fault_address_reported_from_mpk_protected_memory in #7622

Steps to Reproduce

  • Checkout the PR (e.g., gh pr checkout 7622)
  • On an aarch64 machine, run cargo test -- traps::wasm_fault_address_reported_from_mpk_protected_memory

Expected Results

The test to pass.

Actual Results

The test fails because the error message contains 0xdeadbee8 instead of the expected 0xdeadbeef. This likely is an endianness issue causing the calculation of WasmFault (see Store::wasm_fault, e.g.) to be slightly off.

Versions and Environment

Wasmtime version or commit: #7622

Operating system: Reproduced in the "Linux arm64" CI runner (here)

Architecture: aarch64

@abrown abrown added the bug Incorrect behavior in the current implementation that needs fixing label Dec 1, 2023
@alexcrichton
Copy link
Member

Ah this is expected platform-specific behavior (I think we raced with my comment), so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior in the current implementation that needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants